Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use blocktank host env var to setup client #1801

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: use blocktank host env var to setup client #1801

merged 1 commit into from
May 8, 2024

Conversation

Jasonvdb
Copy link
Collaborator

@Jasonvdb Jasonvdb commented May 8, 2024

Description

  • Updates Blocktank client to use env var in preparation for using the new server

Linked Issues/Tasks

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

QA Notes

@Jasonvdb Jasonvdb marked this pull request as ready for review May 8, 2024 10:44
limpbrains
limpbrains requested changes May 8, 2024
View reviewed changes
src/utils/blocktank/index.ts Outdated Show resolved Hide resolved
@Jasonvdb Jasonvdb merged commit f69dfa6 into master May 8, 2024
6 checks passed
@Jasonvdb Jasonvdb deleted the new-bt-server branch May 8, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limpbrains limpbrains limpbrains approved these changes

@coreyphillips coreyphillips Awaiting requested review from coreyphillips

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jasonvdb @limpbrains