fix: switch unit on confirmation screen #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limpbrains
force-pushed
the
fixfixfix2
branch
3 times, most recently
from
da4faf1
to
39b58c8
Compare
You sure this is how it should work? The design still has this button. |
limpbrains
changed the title
I've updated the PR. Button is not removed |
pwltr
requested changes
Jun 12, 2024
pwltr
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
onChangeUnitOutsidecallback to make it workLinked Issues/Tasks
closes #1792 #1926
Type of change
Bug fix
Tests
Detox test
Screenshot / Video
QA Notes