Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): Fix Boost Fee Conversion #1825

Merged
merged 1 commit into from
May 15, 2024
Merged

fix(wallet): Fix Boost Fee Conversion #1825

merged 1 commit into from
May 15, 2024

Conversation

coreyphillips
Copy link
Collaborator

Description

Linked Issues/Tasks

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Tests

  • No test

QA Notes

  • Have the wallet send Bitcoin to itself by copying the Receive address and then sending an amount to it (Not the max amount). Afterwards, tap on the transaction from the activity list and proceed to boost it. Previously, the boost would result in an amount that displays decimals as shown in this issue. As of this PR the amount should be accurate and not display decimals as showcased in the linked issue.

@coreyphillips
fix(wallet): Fix Boost Fee Conversion
27ead34 
Removes btcToSats method when calculating boost fees.
Fixes #1816
@coreyphillips coreyphillips added the bug Something isn't working label May 14, 2024
@coreyphillips coreyphillips added this to the v.1 milestone May 14, 2024
@coreyphillips coreyphillips requested a review from pwltr May 14, 2024 13:55
@coreyphillips coreyphillips self-assigned this May 14, 2024
@coreyphillips coreyphillips merged commit 53a92a1 into master May 15, 2024
6 checks passed
@coreyphillips coreyphillips deleted the fix/boost-fee-conversion branch May 15, 2024 13:06
@catch-21
Copy link
Contributor

Verified in v118 by following steps in QA Notes. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwltr pwltr pwltr approved these changes

Assignees

@coreyphillips coreyphillips

Labels
bug Something isn't working
Projects
None yet
Milestone
v.1
Development

Successfully merging this pull request may close these issues.

[Bug]: Fraction of sat can be temporarily shown in onchain send details
3 participants
@coreyphillips @catch-21 @pwltr