Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): update copy #1875

Merged
merged 1 commit into from
May 24, 2024
Merged

fix(ui): update copy #1875

merged 1 commit into from
May 24, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented May 24, 2024

Description

Completes the following tasks from prototype v48:

  • Onboarding: Updated copy for various onboarding frames (headings + paragraphs).
  • Onboarding > Wallet: Placed emphasis on ‘Don’t store all your money in Bitkit’.
  • Wallet overview: Removed the ‘Don’t store all your money in Bitkit’ warning card from the wallet overview.
  • Suggestion card ‘SPEND’: Changed second line to ‘Instant payments’ to highlight the benefit of funding and setting up a spending balance.
  • Progress card ‘TRANSFER’: Changed second line to only ‘In progress..’ for all steps of the LN setup process. User can tap on card to see more details about the process in the full screen setup flow.
  • Buy Bitcoin: Changed heading to: ‘BUY SOME BITCOIN’ and label of button to ‘Choose Exchange’
  • Connection Closed: Changed copy to: ‘Your Lightning Connection has closed. Your funds transferred to your savings.’
  • Restore error: Changed copy to: ‘SPENDING BALANCE ERROR’
  • Restore error: Updated the paragraph copy for the spending balance error.
  • Profile onboarding: Changed paragraph copy.
  • Contacts onboarding: Changed graphic to 3D ‘users’ icon.
  • Widgets onboarding: Removed second onboarding screen (passwordless accounts)
  • Backup: Removed ‘Export wallet data to phone’ option
  • Backup flow: Rearranged ‘Successful’ and ‘Keep It Secret’, changed title to ‘Keep It Safe’. https://synonymworkspace.slack.com/archives/C01J0QPPV08/p1714997788429509
  • Transfer to Savings frames: Updated paragraph copy for channel closure frames. Changed channel closure confirmation graphic to 3D checkmark.
  • Settings > Close Connection: Updated paragraph copy for channel closure frame.
  • Transfer > In Transfer: Updated paragraph copy (removes the necessity to keep app open).

Linked Issues/Tasks

#1864

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

@pwltr pwltr requested a review from limpbrains as a code owner May 24, 2024 09:05
@pwltr pwltr merged commit 73c1f0e into master May 24, 2024
6 checks passed
@pwltr pwltr deleted the fix/copy branch May 24, 2024 10:00
@pwltr pwltr self-assigned this May 28, 2024
@catch-21
Copy link
Contributor

why not all from v48? these are the ones not pulled into this PR:

  • Contrast: Changed alpha values for copy from #FFFFFF 50% to #FFFFFF 64%.
  • Suggestion cards: Changed letter spacing from -1px to -0.5px for the 20px headings on the cards
  • Suggestion cards: Updated default sets for empty and funded wallet states
  • Progress card ‘FAILED’: Changed colors for this card to Bitkit orange.
  • Widgets: Added the Bitcoin price widget (1D USD) as a default preinstalled widget on fresh installs.
  • Toasts: Please add 1 second to ‘Switched to dollars’, Wallet Balance Hidden’, and ‘Spending Balance Ready’
  • Savings Overview: Added empty state
  • Spending Overview: Added empty state
  • Update modal: Updated visual design and layout.
  • Forced update: Updated visual design and layout.
  • Force transfer modal: Updated visual design and layout.
  • Transfer failure modal: Updated visual design and layout.
  • Transfer failure modal: Changed graphic to 3D ‘X’ icon.
  • High balance modal: Updated visual design and layout.
  • Buttons: Added pressed state for regular buttons (see design system)
  • Settings > General: Added setting for user to choose between orange or black app icon (default=orange)
  • Max amount: Added max amount modal with short explanation for end user for when ‘max’ amount is tapped in spending balance send flow.
  • Transaction Failed: Added ‘Send Anonymous Report’ button.

@catch-21
Copy link
Contributor

catch-21 commented May 31, 2024

Tested on 6c75bd0
Mostly good. Here are some discrepancies:

  1. Buy Bitcoin: Changed heading to: ‘BUY SOME BITCOIN’ and label of button to ‘Choose Exchange’ Capitalise 'E' in 'exchange'
  2. Backup flow: Rearranged ‘Successful’ and ‘Keep It Secret’, changed title to ‘Keep It Safe’. This has not changed.
  3. Suggestion card ‘SPEND’: Changed second line to ‘Instant payments’ to highlight the benefit of funding and setting up a spending balance. This has not changed.
  4. Onboarding > Wallet: Placed emphasis on ‘Don’t store all your money in Bitkit’. There's an alignment difference between figma and on the devices I tested on that makes this text not appear on a new line.
  5. The period at end of the following three have been removed in figma:
    5a. 'TO GET STARTED SEND BITCOIN TO YOUR WALLET'
    5b. 'SEND BITCOIN TO YOURS SAVINGS BALANCE'
    5C. 'SEND BITCOIN TO YOURS SPENDING BALANCE'

@pwltr pwltr mentioned this pull request Jun 3, 2024
4 tasks
@pwltr
Copy link
Collaborator Author

pwltr commented Jun 3, 2024

Mostly good. Here are some discrepancies:

Could only reproduce 1 & 5. Fixed here

Please double-check Figma vs. App

Please double-check in App

Fonts can be rendered differently in app vs. Figma, we can't really ensure equal line breaking, also this depends heavily on screen size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants