Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add default widget #1881

Merged
merged 3 commits into from
May 27, 2024
Merged

feat: add default widget #1881

merged 3 commits into from
May 27, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented May 24, 2024

Description

  • Widgets: Added the Bitcoin price widget (1D USD) as a default preinstalled widget on fresh installs.
  • Backup: backup on delete widget
  • rename slashtags2 -> slashtags

Linked Issues/Tasks

#1864

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

@limpbrains
Copy link
Collaborator

initialSlashtagsState.profiles should be removed.
Also, please, rename src/utils/slashtags2

@pwltr pwltr force-pushed the feat/add-default-widget branch 2 times, most recently from cbcaa3d to 92f859c Compare May 24, 2024 10:55
@pwltr pwltr requested a review from limpbrains May 24, 2024 10:59
@limpbrains
Copy link
Collaborator

Any idea why e2e test keeps failing? Maybe try to workaround it?

@socket-security Socket Security
Copy link

socket-security bot commented May 25, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, filesystem 0 32.5 kB isaacs
npm/[email protected] None 0 12.8 kB ljharb
npm/[email protected] None 0 20.6 kB ljharb
npm/[email protected] None +1 27.9 kB ljharb
npm/[email protected] None 0 38.9 kB mridgway
npm/[email protected] None 0 712 kB adrai
npm/[email protected] None 0 635 kB adrai
npm/[email protected] None 0 6.8 kB feross
npm/[email protected] environment 0 623 kB mweststrate
npm/[email protected] Transitive: filesystem, unsafe +3 19.8 kB sindresorhus
npm/[email protected] None 0 3.96 kB isaacs
npm/[email protected] None 0 226 kB longlho
npm/[email protected] None 0 13.6 kB indutny
npm/[email protected] None 0 11.9 kB ljharb
npm/[email protected] None 0 28.9 kB ljharb
npm/[email protected] None +1 41.1 kB ljharb
npm/[email protected] None +1 31.7 kB ljharb
npm/[email protected] filesystem 0 3.01 kB sindresorhus
npm/[email protected] None +1 19.8 kB phated
npm/[email protected] None +1 30 kB ljharb
npm/[email protected] None 0 22 kB ljharb
npm/[email protected] environment, filesystem 0 3.76 kB sindresorhus
npm/[email protected] None 0 3.89 kB juliangruber
npm/[email protected] None 0 29.3 kB oss-bot
npm/[email protected] Transitive: filesystem +3 353 kB oss-bot
npm/[email protected] None 0 707 kB dmester
npm/[email protected] None 0 15.1 kB lydell
npm/[email protected] None 0 235 kB jordanbtucker
npm/[email protected] None 0 1.41 MB bnjmnt4n
npm/[email protected] environment 0 5.81 kB zertosh
npm/[email protected] None 0 292 kB matinzd
npm/[email protected] None 0 8.9 kB zensh
npm/[email protected] None 0 206 kB dougwilson
npm/[email protected] None 0 18.3 kB dougwilson
npm/[email protected] None 0 60.1 kB broofa
npm/[email protected] None 0 1.55 kB cwmma
npm/[email protected] None 0 54.5 kB ljharb
npm/[email protected] filesystem 0 7.69 kB isaacs
npm/[email protected] None 0 21.7 kB ai
npm/[email protected] None 0 298 kB suguru03
npm/[email protected] None 0 34 kB chicoxyzzy
npm/[email protected] None 0 5.49 kB sindresorhus
npm/[email protected] None 0 97.2 kB ljharb
npm/[email protected] None +1 10.6 kB sindresorhus
npm/[email protected] None 0 4.55 kB sindresorhus
npm/[email protected] None 0 90 kB mrmlnc
npm/[email protected] unsafe 0 13.4 kB danez
npm/[email protected] environment, filesystem, unsafe 0 11.2 MB prettier-bot
npm/[email protected] None 0 15.3 kB cwmma
npm/[email protected] None +2 203 kB terkelg
npm/[email protected] environment 0 94.5 kB ljharb
npm/[email protected] None 0 8.37 kB feross
npm/[email protected] None 0 11 kB nzh
npm/[email protected] None +2 390 kB adrai
npm/[email protected] environment 0 24 kB acdlite
npm/[email protected] None 0 68.7 MB coreyphillips
npm/[email protected] None 0 169 kB jayfunk
npm/[email protected] None 0 264 kB scarlac
npm/[email protected] None 0 682 kB schie
npm/[email protected] environment, filesystem +1 101 kB goatandsheep
npm/[email protected] None 0 523 kB computerjazz
npm/[email protected] None 0 40.3 kB wumke
npm/[email protected] None 0 40.9 kB acostalima
npm/[email protected] None 0 570 kB hagen
npm/[email protected] None +3 4.11 MB jakub.piasecki
npm/[email protected] None 0 696 kB mkuczera
npm/[email protected] None 0 178 kB johandutoit
npm/[email protected] None 0 30.1 kB ardaogulcan
npm/[email protected] None 0 205 kB oblador
npm/[email protected] None 0 125 kB zoontek
npm/[email protected] None 0 3.24 MB mrousavy
npm/[email protected] None 0 72.7 kB mmazzarolo
npm/[email protected] None 0 518 kB zoontek
npm/[email protected] network +1 7.63 MB acostalima
npm/[email protected] None 0 144 kB awesomejerry
npm/[email protected] None 0 532 kB jordanbyron
npm/[email protected] None 0 2.11 MB craftzdog
npm/[email protected] None 0 821 kB mrousavy
npm/[email protected] None 0 55.9 kB tenaciousmv
npm/[email protected] None 0 595 kB zhaodonghao586
npm/[email protected] environment, eval +2 3.66 MB piaskowyk
npm/[email protected] Transitive: environment, filesystem, shell +1 868 kB skapala
npm/[email protected] None 0 599 kB avishayil
npm/[email protected] environment 0 236 kB janicduplessis
npm/[email protected] None +2 1.3 MB tboba
npm/[email protected] None 0 317 kB mateusandrade
npm/[email protected] network +9 4.92 MB wolewicki
npm/[email protected] None +1 182 kB rapsssito
npm/[email protected] None 0 42 kB calintamas
npm/[email protected] None 0 114 kB plrthink
npm/[email protected] environment, network Transitive: eval +20 103 MB react-native-bot
npm/[email protected] environment 0 739 kB acemarke
npm/[email protected] environment 0 316 kB gnoff
npm/[email protected] None 0 34.3 kB evgenyrodionov
npm/[email protected] environment 0 418 kB rt2zz
npm/[email protected] None 0 26.8 kB acemarke
npm/[email protected] None 0 290 kB phryneas
npm/[email protected] None 0 27.8 kB benjamn
npm/[email protected] None 0 29.3 kB darleikroth
npm/[email protected] None 0 111 kB gevorg94
npm/[email protected] None 0 32.1 kB feross
npm/[email protected] None 0 42.3 kB chalker
npm/[email protected] None 0 1.89 MB fanatid
npm/[email protected] None 0 68.3 kB lukekarrys
npm/[email protected] None +2 43.4 kB dougwilson
npm/[email protected] None +2 36.2 kB ljharb
npm/[email protected] None 0 31.1 kB dcousens
npm/[email protected] None 0 45 kB ljharb
npm/[email protected] None 0 9.96 kB isaacs
npm/[email protected] None 0 13.4 MB pwltr
npm/[email protected] None 0 805 kB tromey
npm/[email protected] None 0 11.6 kB goto-bus-stop
npm/[email protected] None 0 15.3 kB matteo.collina
npm/[email protected] None 0 4.03 kB sindresorhus
npm/[email protected] environment +2 3.03 MB probablyup
npm/[email protected] None 0 60 kB typescript-bot
npm/[email protected] None 0 32.4 MB typescript-bot
npm/[email protected] None 0 4.31 kB dougwilson
npm/[email protected] filesystem, shell Transitive: environment +2 30.9 kB ai
npm/[email protected] None +2 78.5 kB swaagie
npm/[email protected] None 0 5.48 kB tootallnate
npm/[email protected] None 0 123 kB ctavan
npm/[email protected] filesystem +2 14.6 kB daaku
npm/[email protected] environment Transitive: filesystem +1 20.4 kB isaacs
npm/[email protected] network 0 122 kB lpinca
npm/[email protected] environment, filesystem 0 128 kB oss-bot

🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@noble/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native-community/[email protected], npm/@react-native/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented May 25, 2024 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: tar -xzf libsodium/build.tgz --directory ./libsodium

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@pwltr pwltr merged commit e0ac43c into master May 27, 2024
5 of 6 checks passed
@pwltr pwltr deleted the feat/add-default-widget branch May 27, 2024 10:05
@pwltr pwltr self-assigned this May 28, 2024
@catch-21
Copy link
Contributor

Verified on 8de4fa7
BTC/USD price widget set as default and backup is stored when it is deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limpbrains limpbrains limpbrains approved these changes

Assignees

@pwltr pwltr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwltr @limpbrains @catch-21