Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump @synonymdev/react-native-keychain to v9.1.1 #2336

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

limpbrains
Copy link
Collaborator

Description

Update to this fork synonymdev/react-native-keychain#2

Linked Issues/Tasks

closes #1916 #2332

Type of change

Bug fix

Tests

No test

Screenshot / Video

QA Notes

Copy link

socket-security bot commented Nov 7, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@synonymdev/[email protected] None 0 257 kB limpbrains

🚮 Removed packages: npm/@synonymdev/[email protected]

View full report↗︎

@limpbrains limpbrains requested a review from pwltr November 7, 2024 12:07
@pwltr
Copy link
Collaborator

pwltr commented Nov 7, 2024

Needs Podfile update?

@limpbrains
Copy link
Collaborator Author

Updated

@limpbrains
Copy link
Collaborator Author

@ovitrif
Locally, it works fine, but on GitHub Actions, the seed never loads, even after 30 seconds.
Additionally, there are no errors in the application log.
Here's an example of the text run:

test.mp4

setPassphrase(bip39PassphraseResult);
};

getSeed();
}, [t]);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ovitrif
I've fixed the issue that, I was complaining about earlier, by removing concurrent requests for the keychain.
It is ok, but I think there is a bug in keychain library, maybe you are intrested

@limpbrains limpbrains marked this pull request as ready for review November 8, 2024 12:59
@limpbrains limpbrains merged commit 5e2b912 into master Nov 8, 2024
7 checks passed
@limpbrains limpbrains deleted the keychain-v9 branch November 8, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Hot reloading on Android broken
2 participants