Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial 10.13 High Sierra Deploy #156

Open
wants to merge 52 commits into
base: master
Choose a base branch
from

Conversation

mircoianese
Copy link

@mircoianese mircoianese commented Oct 24, 2017

Hello.
I have edited Deploy.sh to fix some High Sierra issue I have encountered and to correctly patch some other things. Please have a look and report back if you have any issue.

Thank you!

Note: Actual PixelClock Patch for QHD Display breaks Clipboard on High Sierra. This script uses CoreDisplayFixUp.kext + Lilu.kext (both in Clover/kexts). If you already have patched with previous Deploy, you need to restore the Vanilla CoreDisplay.framework to make the Clipboard work again.
If you clean install and run directly this new Deploy then you shouldn't experience this issue.

Note 2: Final Deploy is in last commit. Deploy in the previous one had one bug.

@mircoianese
Copy link
Author

@chenyisen tested the script and reported all the issue he got. Script is now fixed and should work correctly on both Sierra and High Sierra.

Please report back any other issue you may encounter.

@vinv
Copy link

vinv commented Oct 26, 2017

Hi,

I currently have Sierra and have run syscl's Deploy script. If I wanted to try yours, do I first install High Sierra (via the App Store), then run your script or is there a different recommended upgrade procedure?

Vin

@mircoianese
Copy link
Author

mircoianese commented Oct 26, 2017 via email

@mircoianese
Copy link
Author

@vinv Also please if you could provide Deploy.sh log and you Clover folder after patching the system that would be really appreciated. Just to check if the script worked correctly!

Thank you!

@syscl
Copy link
Owner

syscl commented Oct 27, 2017

Thank you for your effort! But I haven’t experienced Pixel Clock patch break clipboard issue on 10.13 and not even happened on my M3800 either. Do you have any links indicating this patch breaks clipboard on 10.13?

Thank you in advanced,
syscl

@mircoianese
Copy link
Author

mircoianese commented Oct 27, 2017 via email

@syscl
Copy link
Owner

syscl commented Oct 27, 2017

Thank you, since I have Iris model this I never worry about this patch but I have found a new one could you please help me to see if it works or not?

Thank you in advanced,
syscl

@mircoianese
Copy link
Author

mircoianese commented Oct 27, 2017 via email

@syscl
Copy link
Owner

syscl commented Oct 27, 2017

Remove CoreDisplayFixup and try this patch to see if Clipboard corrupt or not

sudo perl -i.bak -pe 's|\xB8\x01\x00\x00\x00\xF6\xC1\x01\x0F\x85|\x48\x33\xC0\x90\x90\x90\x90\x90\x90\xE9|sg' /System/Library/Frameworks/CoreDisplay.framework/Versions/Current/CoreDisplay
sudo codesign -f -s - /System/Library/Frameworks/CoreDisplay.framework/Versions/Current/CoreDisplay

Thank you in advanced,
syscl

@mircoianese
Copy link
Author

mircoianese commented Oct 27, 2017 via email

@mircoianese
Copy link
Author

mircoianese commented Oct 27, 2017

@syscl That broke clipboard. Reverting back to CoreDisplayFixup
How do I restore the Vanilla File? Tried to replace it with mine and codesign again. Copy-Paste still not working

@PMheart
Copy link

PMheart commented Oct 27, 2017

That's really weird then. I think CoreDisplayFixup is doing totally the same thing: https://github.com/PMheart/CoreDisplayFixup/blob/master/CoreDisplayFixup/IntelPatcher.cpp#L35
As for file restoring. Don't you have an untouched CoreDisplay backup?

EDIT: Oh. @syscl 's command should create one. So just

sudo rm /System/Library/Frameworks/CoreDisplay.framework/Versions/A/CoreDisplay
sudo cp /System/Library/Frameworks/CoreDisplay.framework/Versions/A/CoreDisplay.bak /System/Library/Frameworks/CoreDisplay.framework/Versions/A/CoreDisplay

You probably need to disable SIP's FS protection before doing so. I suppose that you've done it though.

@syscl
Copy link
Owner

syscl commented Oct 27, 2017

No need to remove just move back is enough.

Edited: I have M3800 with same binary patch without any problems on 10.13(just updated to latest with APFS).

syscl

@syscl
Copy link
Owner

syscl commented Nov 1, 2017

Hi Zombie, please do whatever you like this period I will look into it in the future. I am sorry that I still have a lot of projects and exams, and I am a TA/RA for operating system course as well. Life is busy for me these days. Sorry for my late reply.

syscl

@syscl
Copy link
Owner

syscl commented Feb 7, 2018

Hi @maz-1 @ZombieTheBest , Iris model still require CoreDisplayPatch?

Thank you in advance,
syscl

@maz-1
Copy link
Collaborator

maz-1 commented Feb 8, 2018

CoreDisplayPatch can help reducing boot logo glitch to minimum

@syscl
Copy link
Owner

syscl commented Feb 8, 2018

@maz-1 no, that’s not CoreDisplay patch reduces the boot glitches but CSM and framebuffer that fix the boot glitches.

Iris Model did not need CoreDisplay patch.

@maz-1
Copy link
Collaborator

maz-1 commented Feb 8, 2018

Fine, pick commits you need then

@AurelienKun
Copy link

Is this abandonned ?

@syscl
Copy link
Owner

syscl commented Jun 10, 2020

@AurelienKun This is not abandon, but seems I cannot merge this PR @mircoianese

@mircoianese
Copy link
Author

@AurelienKun This is not abandon, but seems I cannot merge this PR @mircoianese

Hi, this is a super-late response but had no notifications on this thread.
Unfortunately I do not own this laptop anymore so I can't help with this. I have also forgot most of the things that were done in this PR.

Sorry I can't help

@liuzhu007
Copy link

liuzhu007 commented Sep 5, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants