fix(node-analyzer): enable hostPID in node-analyzer #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Values.global.kspm.deploy is set to true. This ensures that calls to systemctl during analysis will not fail
github-actions
bot
added
the
no-tests
mavimo
reviewed
Jul 27, 2023
charts/node-analyzer/Chart.yaml
Outdated
| @@ -3,7 +3,7 @@ name: node-analyzer | |||
| description: Sysdig Node Analyzer | |||
|
|
|||
| # currently matching Sysdig's appVersion 1.14.34 | |||
| version: 1.11.3 | |||
| version: 1.11.4 | |||
There was a problem hiding this comment.
It seems a behavioural change, I suggest to bump it as a minor, not as patch release.
There was a problem hiding this comment.
@mavimo thanks. done :)
…ensure hostPID is set correctly
github-actions
bot
removed
the
no-tests
chen-shmilovich-sysdig
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
modify node-analyzer Helm chart and enable hostPID when
.Values.global.kspm.deployis set totrue. This ensures that calls tosystemctlduring analysis will not fail.See SSPROD-27133 for more details
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
Check Contribution guidelines in README.md for more insight.