Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node-analyzer): toggle volumes used by runtimeScanner and imageAnalyzer #1273

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

francesco-furlan
Copy link
Contributor

@francesco-furlan francesco-furlan commented Jul 31, 2023

What this PR does / why we need it:

Don't mount volumes needed just for runtimeScanner and imageAnalyzer when their both disabled.
This is needed since GKE autopilot doesn’t allow mounting volumes not used.
Preliminary work for SMAGENT-5237 and SMAGENT-5236

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Jul 31, 2023
@francesco-furlan francesco-furlan requested a review from a team as a code owner July 31, 2023 09:35
@francesco-furlan francesco-furlan marked this pull request as draft July 31, 2023 10:49
@francesco-furlan francesco-furlan force-pushed the toggle-volumes-mount-on-node-analyzer branch from 2b18561 to 49b25c1 Compare August 1, 2023 13:30
@francesco-furlan francesco-furlan force-pushed the toggle-volumes-mount-on-node-analyzer branch from 4c6a0b0 to 68d8008 Compare August 2, 2023 15:52
@francesco-furlan francesco-furlan changed the title chore(node-analyzer): toggle volumes used by runtimeScanner chore(node-analyzer): toggle volumes used by runtimeScanner and imageAnalyzer Aug 2, 2023
@francesco-furlan francesco-furlan marked this pull request as ready for review August 2, 2023 16:09
@AlbertoBarba AlbertoBarba self-requested a review August 3, 2023 07:48
@francesco-furlan francesco-furlan merged commit d59b8c9 into master Aug 3, 2023
8 checks passed
@francesco-furlan francesco-furlan deleted the toggle-volumes-mount-on-node-analyzer branch August 3, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-tests Chart templates modified without test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants