Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(agent): Fix global.sysdig.accessKeySecret in README.md #1295

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

airadier
Copy link
Collaborator

@airadier airadier commented Aug 9, 2023

What this PR does / why we need it:

Fix wrong name of global.sysdig.existingAccessKeySecret (should be accessKeySecret)

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@airadier airadier requested a review from a team as a code owner August 9, 2023 10:54
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests

@airadier airadier changed the title Fix global.sysdig.accessKeySecret in README.md (agent): Fix global.sysdig.accessKeySecret in README.md Aug 9, 2023
@github-actions github-actions bot dismissed their stale review August 9, 2023 10:55

All good!

@airadier airadier merged commit b99f852 into master Aug 9, 2023
5 checks passed
@airadier airadier deleted the fix-agent-readme branch August 9, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants