Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(registry-scanner): user/passwords field optionals when dockerv2 #1296

Closed
wants to merge 2 commits into from
Closed

feat(registry-scanner): user/passwords field optionals when dockerv2 #1296

wants to merge 2 commits into from

Conversation

miketnt
Copy link
Contributor

@miketnt miketnt commented Aug 9, 2023 •
edited by mavimo
Loading

What this PR does / why we need it:

Removes the requirement for registryUser and registryPassword

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Aug 9, 2023
@miketnt miketnt marked this pull request as ready for review August 9, 2023 19:11
@miketnt miketnt requested review from a team as code owners August 9, 2023 19:11
@miketnt
Copy link
Contributor Author

miketnt commented Aug 10, 2023

Closing this one, we don't want generic dockerv2 type to run without authentication

@miketnt miketnt closed this Aug 10, 2023
@mavimo mavimo deleted the update-dockerv2-required-fields branch October 21, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wideawakening wideawakening wideawakening approved these changes

@giuse-sysdig giuse-sysdig Awaiting requested review from giuse-sysdig

Assignees
No one assigned
Labels
no-tests Chart templates modified without test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miketnt @wideawakening