fix(shield): apply kspm_analyzer agent app name #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kspm analyzer requires the 'agent_app_name' parameter to be set to the value given to the 'app.kubernetes.io/name' label on the host shield pod, which is 'shield' when installed via the shield chart.
correct source of agent_app_name value Co-authored-by: Alberto Barba <[email protected]>
fix syntax error Co-authored-by: Alberto Barba <[email protected]>
aroberts87
force-pushed
the
aroberts/fix/shield-agent-app-name
branch
from
5792813
to
1c43bcb
Compare
AlbertoBarba
approved these changes
Oct 29, 2024
fnonay
pushed a commit
that referenced
this pull request
Oct 30, 2024
Co-authored-by: Alberto Barba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The kspm analyzer requires the
agent_app_nameparameter to be set to the value given to theapp.kubernetes.io/namelabel on the host shield pod, which isshieldwhen installed via the shield chart.Checklist
feat(agent,node-analyzer,sysdig-deploy):)