feat(sysdig-agent,node-analyzer,kspm-collector,rapid-response,admission-controller): Global Custom CA Bundle Support #961
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests
github-actions
bot
added
the
no-tests
saltycr3w
changed the title
saltycr3w
changed the title
github-actions
bot
removed
the
no-tests
saltycr3w
changed the title
mavimo
force-pushed
the
global-ssl-ca-cert
branch
from
e8d5820
to
543846e
Compare
mavimo
force-pushed
the
global-ssl-ca-cert
branch
3 times, most recently
from
860fba2
to
915eb14
Compare
AlbertoBarba
force-pushed
the
global-ssl-ca-cert
branch
12 times, most recently
from
168a145
to
de3e5f7
Compare
AlbertoBarba
force-pushed
the
global-ssl-ca-cert
branch
from
de3e5f7
to
5ac9ce7
Compare
AlbertoBarba
force-pushed
the
global-ssl-ca-cert
branch
3 times, most recently
from
8de0cc6
to
15bebf5
Compare
AlbertoBarba
requested review from
a team
and removed request for
github-actions[bot]
AlbertoBarba
force-pushed
the
global-ssl-ca-cert
branch
11 times, most recently
from
c5c4120
to
58a5e4e
Compare
AlbertoBarba
force-pushed
the
global-ssl-ca-cert
branch
from
58a5e4e
to
5bae18b
Compare
| # -----END CERTIFICATE----- | ||
|
|
||
| # Filename that is used when creating the secret. Required if cert is provided. | ||
| keyName: root_ca_file.crt |
There was a problem hiding this comment.
Remove the default here (the default is missing in all the other entries)
There was a problem hiding this comment.
Removing the default here will cause a BC since the current version of rapid-response already accept the .Values.ssl.ca.certs and automatically names it in https://github.com/sysdiglabs/charts/pull/961/files#diff-4dd3290c87066c244c1311d77bc14f6a87e30ceb1bdf42ca0f67239c738854e6L38
There was a problem hiding this comment.
Ok. Semi-related question: why we don't have the default file name in all the charts? 😅
There was a problem hiding this comment.
Cause almost everywhere else we didn't have this functionality yet...the name has been added here to not cause any issue to who's already using this on rapid-response.
AlbertoBarba
force-pushed
the
global-ssl-ca-cert
branch
from
5bae18b
to
a363ca0
Compare
…nning,harbor-scanner-sysdig-secure,kspm-collector,node-analyzer,rapid-response,sysdig-deploy,sysdig-mcm-navmenu,sysdig-stackdriver-bridge) Add Custom CA Support
AlbertoBarba
force-pushed
the
global-ssl-ca-cert
branch
from
a363ca0
to
4157b07
Compare
What this PR does / why we need it:
This PR adds Global Custom CA Bundles support inside the relevant components.
sysdig-agent(Complete)node-analyzer(Complete)kspm-collector(Complete)rapid-response(Complete)Rapid Response has local chart Custom CA Support already, this PR takes that into account and adds onto it.
admission-controller(Complete)admission-controller has local chart Custom CA Support for the scanner and webhook, this PR takes that into account and adds onto it.
TODO
Add more documentation about usage.
Checklist