Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Readme] Added Base Sepoila details to the list of Currently supported chains #509

Closed

Conversation

Ultra-Tech-code
Copy link
Contributor

@Ultra-Tech-code Ultra-Tech-code commented Jul 5, 2024

Summary

Base Sepolia is supported, but it wasn't mentioned in the README. I've added it here.

Details

  • Adds new chain for base sepolia, chain ID 84532, contract at 0xA85aAE9f0Aec5F5638E5F13840797303Ab29c9f9

How it was tested

Verfied at this link 0xA85aAE9f0Aec5F5638E5F13840797303Ab29c9f9

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Contract Addresses

Chain Chain ID Contract
homestead 1 0x012969f7e3439a9B04025b5a049EB9BAD82A8C12
optimism 10 0xfad44BF5B843dE943a09D4f3E84949A11d3aa3e6
arbitrum 42161 0x9aBd75E8640871A5a20d3B4eE6330a04c962aFfd
arbitrum-nova 42170 0x1A22854c5b1642760a827f20137a67930AE108d2
polygon 137 0x5c4e6A9e5C1e1BF445A062006faF19EA6c49aFeA
filecoin 314 0x59EF8Bf2d6c102B4c42AEf9189e1a9F0ABfD652d
sepolia 11155111 0xc50C62498448ACc8dBdE43DA77f8D5D2E2c7597D
optimism-sepolia 11155420 0x68A2f4423ad3bf5139Db563CF3bC80aA09ed7079
arbitrum-sepolia 421614 0x223A74B8323914afDC3ff1e5005564dC17231d6e
base-sepolia 84532 0xA85aAE9f0Aec5F5638E5F13840797303Ab29c9f9
polygon-amoy 80002 0x170fb206132b693e38adFc8727dCfa303546Cec1
filecoin-calibration 314159 0x030BCf3D50cad04c2e57391B12740982A9308621

added base-sepolia to the list of supported chains.

Signed-off-by: Adewale IyanuOluwa Isaac <[email protected]>
@joewagner
Copy link
Contributor

@Ultra-Tech-code Thanks for this PR.
Can you run npm run prettier:fix on your branch? Looks like your formatting doesn't match our prettier rules.

@Ultra-Tech-code
Copy link
Contributor Author

@Ultra-Tech-code Thanks for this PR. Can you run npm run prettier:fix on your branch? Looks like your formatting doesn't match our prettier rules.

i've ran the command

joewagner
joewagner previously approved these changes Jul 9, 2024
@joewagner
Copy link
Contributor

@Ultra-Tech-code This looks great! We also have a requirement that commits are signed, are you able to sign your commits? If not we can work around it, but if its not too much trouble that would ensure you get the proper credit for the commits on github

@dtbuchholz
Copy link
Contributor

@Ultra-Tech-code
Copy link
Contributor Author

I will go ahead and setup GPG and make a new commit. Thank you

@Ultra-Tech-code
Copy link
Contributor Author

I will go ahead and setup GPG and make a new commit. Thank you

I just signed a new commit now

README.md Outdated Show resolved Hide resolved
@dtbuchholz
Copy link
Contributor

(i'll go ahead and merge this—iirc, only core contributors have the ability to do so.)

@dtbuchholz
Copy link
Contributor

ah, jk...i can't because of the unsigned commit at d80361

@dtbuchholz
Copy link
Contributor

@joewagner i opened a separate PR to make things easier, which at least retains the verified commits for credit purposes. i can either just push to this branch, or we can close this branch and merge it: here

@joewagner
Copy link
Contributor

@joewagner i opened a separate PR to make things easier, which at least retains the verified commits for credit purposes. i can either just push to this branch, or we can close this branch and merge it: here

That looks good to me

@dtbuchholz dtbuchholz closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants