-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Readme] Added Base Sepoila details to the list of Currently supported chains #509
Conversation
added base-sepolia to the list of supported chains. Signed-off-by: Adewale IyanuOluwa Isaac <[email protected]>
@Ultra-Tech-code Thanks for this PR. |
i've ran the command |
@Ultra-Tech-code This looks great! We also have a requirement that commits are signed, are you able to sign your commits? If not we can work around it, but if its not too much trouble that would ensure you get the proper credit for the commits on github |
for reference, here's how to set up GPG signing: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
I will go ahead and setup GPG and make a new commit. Thank you |
I just signed a new commit now |
(i'll go ahead and merge this—iirc, only core contributors have the ability to do so.) |
ah, jk...i can't because of the unsigned commit at d80361 |
@joewagner i opened a separate PR to make things easier, which at least retains the verified commits for credit purposes. i can either just push to this branch, or we can close this branch and merge it: here |
That looks good to me |
Summary
Base Sepolia is supported, but it wasn't mentioned in the README. I've added it here.
Details
0xA85aAE9f0Aec5F5638E5F13840797303Ab29c9f9
How it was tested
Verfied at this link 0xA85aAE9f0Aec5F5638E5F13840797303Ab29c9f9
Checklist:
Contract Addresses