Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: always respond with 200 but include status key #214

Merged
merged 1 commit into from
May 18, 2024
Merged

feat: always respond with 200 but include status key #214

merged 1 commit into from
May 18, 2024

Conversation

petarvujovic98
Copy link
Contributor

image

smtmfft
smtmfft approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@smtmfft smtmfft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just thought maybe 1 more round of message beautify is needed.

Can here "output" replace "data" so the level reduces 1. Not a hard perference though.
image

host/src/server/api/v1/mod.rs Show resolved Hide resolved
@smtmfft
Copy link
Contributor

smtmfft commented May 16, 2024 •
edited
Loading

BTW: I made a new rlpHexBytes serde. so the header will become 0x1234... instead of [18, 52,...]. will have a PR later. What's your opinion? @YoGhurt111 ?

image

@YoGhurt111
Copy link

BTW: I made a new rlpHexBytes serde. so the header will become 0x1234... instead of [18, 52,...]. will have a PR later. What's your opinion? @YoGhurt111 ?

I don't care about header, tbh I only care about proof and message. So I'm fine with either one.

@smtmfft
Copy link
Contributor

smtmfft commented May 18, 2024

Can we merge this one ASAP? then client can integrate & give feedbacks if exist

@petarvujovic98 petarvujovic98 marked this pull request as ready for review May 18, 2024 04:15
@petarvujovic98 petarvujovic98 added this pull request to the merge queue May 18, 2024
Merged via the queue into main with commit 9c13a4f May 18, 2024
7 of 12 checks passed
@petarvujovic98 petarvujovic98 deleted the error-structure branch May 18, 2024 06:38
@github-actions github-actions bot mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smtmfft smtmfft smtmfft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petarvujovic98 @smtmfft @YoGhurt111