Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(raiko): use even more reth #303

Merged
merged 4 commits into from
Jul 2, 2024
Merged

feat(raiko): use even more reth #303

merged 4 commits into from
Jul 2, 2024

Conversation

Brechtpd
Copy link
Contributor

@Brechtpd Brechtpd commented Jul 2, 2024

Mainly

  • header validation now done in reth (except state root), some minor changes on the reth side for this: taikoxyz/taiko-reth@3043c66
  • transactions directly decoded to reth transactions
  • use reth types where possible
  • Tx tree root check was not done correctly before the tx root was calculated on the transactions set in the reth block as passed in, not the transactions decoded from the tx list

Copy link
Contributor

@CeciliaZ030 CeciliaZ030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CeciliaZ030 CeciliaZ030 added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit a51fd42 Jul 2, 2024
16 of 17 checks passed
@CeciliaZ030 CeciliaZ030 deleted the more-reth branch July 2, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants