Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose config using an API #2817

Open
tusharmath opened this issue Sep 15, 2024 · 22 comments
Open

feat: expose config using an API #2817

tusharmath opened this issue Sep 15, 2024 · 22 comments
Assignees

Comments

@tusharmath
Copy link
Contributor

tusharmath commented Sep 15, 2024

Create a new route /graphql which internally exposes a GraphQL API with the following schema

schema {
  query: Query
}

type Query {
  config: Config!
}

type Mutation {
  patch(config: Config!): Status
}

type Config {
  # .. should be auto-generated from config.rs
}

type Status {
  id: ID #For now should return 1
}

Technical Requirements

  • The port should be configurable via server.admin.port setting
  • Update the configuration such that the port is configurable via a server setting. Enable the admin API only when the port is set.
schema @server(admin: {port: 8001}) {
  query: Query
}
@tusharmath
Copy link
Contributor Author

/bounty $200

Copy link

algora-pbc bot commented Sep 15, 2024

💎 $200 bounty • Tailcall Inc.

Steps to solve:

  1. Start working: Comment /attempt #2817 with your implementation plan
  2. Submit work: Create a pull request including /claim #2817 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

🙏 Thank you for contributing to tailcallhq/tailcall!
🧐 Checkout our guidelines before you get started.
💵 More about our bounty program.

Attempt Started (GMT+0) Solution
🔴 @ssddOnTop Sep 15, 2024, 7:46:17 PM WIP
🔴 @karatakis Sep 20, 2024, 9:47:52 AM WIP
🔴 @EveEdwin Sep 24, 2024, 5:54:43 PM WIP
🔴 @TomBebb Nov 8, 2024, 7:12:51 PM WIP

@ssddOnTop
Copy link
Member

ssddOnTop commented Sep 15, 2024

/attempt #2817

Algora profile Completed bounties Tech Active attempts Options
@ssddOnTop 76 tailcallhq bounties
Rust, Java,
C & more
Cancel attempt

Copy link

algora-pbc bot commented Sep 16, 2024

@ssddOnTop: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏

@meskill
Copy link
Contributor

meskill commented Sep 17, 2024

is there a reason to generate a type Config? Schema types are dynamic and will be different for every config, that's will be hard to fetch actually. Apollo federation just uses String to pass the sdl content

Copy link

algora-pbc bot commented Sep 17, 2024

The bounty is up for grabs! Everyone is welcome to /attempt #2817 🙌

@karatakis
Copy link
Contributor

Does the provided mutation update the configuration when the Tailcall service is online?

type Mutation {
  patch(config: Config!): Status
}

@karatakis
Copy link
Contributor

karatakis commented Sep 20, 2024

/attempt #2817

Algora profile Completed bounties Tech Active attempts Options
@karatakis 2 tailcallhq bounties
Rust, JavaScript,
PHP & more
Cancel attempt

Copy link

algora-pbc bot commented Sep 21, 2024

@karatakis: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏

Copy link

algora-pbc bot commented Sep 22, 2024

The bounty is up for grabs! Everyone is welcome to /attempt #2817 🙌

@EveEdwin
Copy link

EveEdwin commented Sep 24, 2024

/attempt #2817

@tusharmath
Copy link
Contributor Author

closing this one in favour of #2903

@tusharmath
Copy link
Contributor Author

@meskill In general its a good idea to have type-safe APIs, that's the whole point of GraphQL and gRPC, however for now I have changed the requirements in #2903 so that we can build this quickly.

Copy link

algora-pbc bot commented Sep 25, 2024

@EveEdwin: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏

Copy link

algora-pbc bot commented Sep 26, 2024

The bounty is up for grabs! Everyone is welcome to /attempt #2817 🙌

@meskill meskill reopened this Oct 1, 2024
@meskill meskill self-assigned this Oct 1, 2024
Copy link

Action required: Issue inactive for 30 days.
Status update or closure in 7 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 31, 2024
@TomBebb
Copy link

TomBebb commented Nov 8, 2024

/attempt #2817

Copy link

algora-pbc bot commented Nov 9, 2024

@TomBebb: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏

Copy link

algora-pbc bot commented Nov 10, 2024

The bounty is up for grabs! Everyone is welcome to /attempt #2817 🙌

@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Nov 16, 2024
@Rushhaabhhh
Copy link

@tusharmath -
Is the issue still open to work and claim the bounty ?

@tusharmath
Copy link
Contributor Author

Not right now. We need to do a bit more work after which this can be worked on.

@Rushhaabhhh
Copy link

@tusharmath Please let me know once its open to work. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants