Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose config through admin api #2955

Closed
wants to merge 1 commit into from
Closed

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Oct 3, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #2817

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 7.40741% with 50 lines in your changes missing coverage. Please review.

Project coverage is 87.47%. Comparing base (aab7e07) to head (4c78a4e).
Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
src/cli/server/admin_server/server.rs 0.00% 43 Missing ⚠️
src/cli/server/http_server.rs 0.00% 5 Missing ⚠️
src/cli/server/admin_server/graphql.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2955      +/-   ##
==========================================
+ Coverage   87.43%   87.47%   +0.03%     
==========================================
  Files         263      267       +4     
  Lines       26422    27015     +593     
==========================================
+ Hits        23103    23631     +528     
- Misses       3319     3384      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 8, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 8, 2024
Copy link

PR closed after 10 days of inactivity.

@github-actions github-actions bot closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: expose config using an API
1 participant