Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change image text detection from .startsWith to in #119

Closed
wants to merge 1 commit into from

Conversation

atopion
Copy link

@atopion atopion commented Mar 22, 2022

First and foremost: Thank you for all your work on this amazing project.

I have had just a small problem with it:
For a significant amount of time, I was unable to get the display function to work. After quite a bit of digging around, I found out that my bash (or maybe ipython) is adding some escape sequences before it, which meant that the searched string was not the actual beginning of the line even if it look like it.

To fix this problem and others like it, I propose to switch from searching the text necessarily at the beginning of the line to searching the text somewhere in the line.

I hope this helps. Thank you again, your work has otherwise been amazing.
Kind regards,
atopion

The image detection text in extract_image_filenames is now detected using "in" instead of "startsWith" to ensure that it also works if bash adds escaped sequences in front of it.
@kdm9 kdm9 mentioned this pull request May 24, 2022
@kdm9
Copy link
Collaborator

kdm9 commented Aug 24, 2022

I've recently taken on co-maintaining bash_kernel, and I'm currently closing all old/stale issues.

I'm closing this issue as it should have been solved in version 0.8 with PR #120. Please test with the latest bash_kernel, and reopen if you need further help.

@kdm9 kdm9 closed this Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants