VkApi refactoring. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreygolubkow
commented
Feb 29, 2024
| @@ -0,0 +1,13 @@ | |||
| namespace TaktTusur.Media.Domain.Common | |||
| { | |||
| public class Copyrights | |||
There was a problem hiding this comment.
Looks like it's not a business logic, just to describe something from VK. Move it to vk api project
| /// <param name="cancellationToken"></param> | ||
| /// <param name="groupId">Идентификатор сообщества.</param> | ||
| /// <param name="count">Количество записей, которое необходимо получить. Максимальное значение: 100</param> | ||
| /// <param name="cancellationToken">Ключ доступа.</param> |
There was a problem hiding this comment.
This is not an access key. msdn link
| 0 => AccessTypes.Accessible, | ||
| 1 => AccessTypes.Inaccessible, | ||
| 2 => AccessTypes.Private, | ||
| _ => throw new NotImplementedException() |
There was a problem hiding this comment.
The same like groups, add unknown
| { | ||
| public class Event | ||
| internal class Event |
There was a problem hiding this comment.
Don't use this name, you can use VkEvent
…ewsFetchingAsyncJob
* PublicEvent class added. * Event import logic implemented. * TaktTusur.Media.Infrastructure.Tests project added. --------- Co-authored-by: Nikita Martsenkovsky <[email protected]> Co-authored-by: andreygolubkow <[email protected]>
…feature/vkapi_refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.