-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer tmux splits and tabs over containing terminal #1116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think this will work in general as implemented.
@EdJoJob Are you still interested in updating this and merging it in? |
I'll work on getting it fixed. Been off GH for a while. Thanks for the patience. |
f2bf95a
to
767cc9b
Compare
fa570fb
to
ed5badb
Compare
Looks good. I reckon just remove the |
Not sure if you intended to push a fix for my previous comment in the last force push, but it hasn't changed the thing I was pointing to. (Just want to make sure we're not both waiting on the other person!). |
f0c039d
to
d1decfe
Compare
I'm in the habit of force-pushing a rebase, and then force-pushing the new changes. Clearly this time I just missed doing the second push. Should be up-to-date now |
One more thing I noticed while testing, the context used by the tab commands doesn't have any matchers on it, so it's not very specific. You probably want to add in a line like this so that Tmux's tab implementation overrides the default one: ctx.matches = "app: tmux" |
d1decfe
to
c811afb
Compare
Done by having the context for matching tmux be a more restrictive match than that of the terminals
c811afb
to
78c830d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for your persistence!
Done by having the context for matching tmux be a more restrictive match than that of the terminals.
This was modeled after the matches for the in-browser Slack and Teams apps.