knausj: rebrand, honor original creator
#1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
reviewed
Jul 13, 2023
| @@ -1,6 +1,11 @@ | |||
| # knausj_talon | |||
| # community | |||
There was a problem hiding this comment.
Suggested change
| # community | |
| # Talon community grammar |
There was a problem hiding this comment.
I'm kind of used to the GitHub convention of the first line being the name of the repository, with a description both underneath and in the repository description field, unless there's a strong reason otherwise. Is this out of date?
I don't feel strongly but I think it looks cleaner this way
There was a problem hiding this comment.
This seems to be the general convention still, I think it's fine as is.
…t to add this much complexity at the top)
pokey
reviewed
Jul 13, 2023
knausj85
approved these changes
Jul 15, 2023
auscompgeek
reviewed
Jul 15, 2023
phillco
changed the title
phillco
changed the title
knausj: rebrand, honor original creator
|
This looks good to me, thanks. |
MartinRykfors
pushed a commit
to MartinRykfors/knausj_talon
that referenced
this pull request
Jul 27, 2023
talonhub#935. We're not in ~Kansas~ knausj anymore... This updates: - The main title of the README (as well as most references therein) and adds a note about our origins. [View here]( https://github.com/talonhub/community/tree/rebrand) - The cloning instructions in the README. - (This might be up for debate; do we want people to `git clone https://github.com/talonhub/community community`? Some users might end up with two copies. I think @lunixbochs had a plan to check for if people have both knausj and community cloned duplicative side by side by mistake.) - GitHub's web UI recommends `https://github.com/talonhub/community.git` as the HTTPS URL, but our old instructions did not include the `.git` suffix. What do we want to do? - All GitHub links in the form of `https://github.com/knausj85/knausj_talon/`, such as to issues. - A few manual references in text files, such as in the deprecation process. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jeff Knaus <[email protected]>
blyons333
pushed a commit
to blyons333/knausj_talon
that referenced
this pull request
Aug 11, 2023
talonhub#935. We're not in ~Kansas~ knausj anymore... This updates: - The main title of the README (as well as most references therein) and adds a note about our origins. [View here]( https://github.com/talonhub/community/tree/rebrand) - The cloning instructions in the README. - (This might be up for debate; do we want people to `git clone https://github.com/talonhub/community community`? Some users might end up with two copies. I think @lunixbochs had a plan to check for if people have both knausj and community cloned duplicative side by side by mistake.) - GitHub's web UI recommends `https://github.com/talonhub/community.git` as the HTTPS URL, but our old instructions did not include the `.git` suffix. What do we want to do? - All GitHub links in the form of `https://github.com/knausj85/knausj_talon/`, such as to issues. - A few manual references in text files, such as in the deprecation process. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jeff Knaus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#935. We're not in
Kansasknausj anymore...This updates:
git clone https://github.com/talonhub/community community? Some users might end up with two copies. I think @lunixbochs had a plan to check for if people have both knausj and community cloned duplicative side by side by mistake.)https://github.com/talonhub/community.gitas the HTTPS URL, but our old instructions did not include the.gitsuffix. What do we want to do?https://github.com/knausj85/knausj_talon/, such as to issues.