-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added voice command to create Talon application context #1242
Conversation
Would recommend you create platform-specific .py/.talon files by default (e.g., visual_studio_code_win.py/talon). Some of us use Talon on more than one platform… |
Is that standard for community now? When I look in the applications folder it's quite rare. |
It's a standard we discussed when we did our last rearrangement. Since keyboard commands usually differ between platforms, my feeling is that if you're using this feature, you may not be an advanced user enough to be able to build a cross-platform implementation. So it's better for the defaults to be "safe" even if the generated file names are a bit more verbose. |
Sounds reasonable |
for more information, see https://pre-commit.ci
…nity into app_context
@nriley Better? |
I'd recommend adding the platform suffix to the .talon file and the app: as well. Also — if you're not watching the log, it doesn't seem like anything happens when I use this command. Perhaps consider opening the directory in the user's file browser, or at the least popping up a notification? |
I don't think it makes sense to have a talon file per os for a single app. Maybe We can talk about this in tomorrow's meetup? |
Yeah, again that seems good as an ideal but not sure if appropriate for a beginning user who may not be comfortable with Python and the "make everything an action" style of implementation. Definitely we should talk about it — might even want to be a setting (argh!) |
@nriley In today's meetup we decided to make the platform name an optional word in the spoken phrase. The current implementation just repeats the command I would prefer to have a list( |
"talon create app context"
will generate a new folder inapps
with a Talon and a python file.Example from visual studio code:
apps/visual_studio_code/visual_studio_code.talon
apps/visual_studio_code/visual_studio_code.py