-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improved eigenlayer context and testing #453
base: main
Are you sure you want to change the base?
Conversation
…t general and reusable
…ing eigen context wip
blueprints/examples/contracts/src/ContextExampleTaskManager.sol
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some changes to fix and improve. Naming needs improvement, it feels robotic. Some test util function for eigen environment should not have been removed IMO as it's a reusable eigen environment system.
|
||
// Create the GadgetConfiguration | ||
let config = ContextConfig { | ||
gadget_core_settings: GadgetCLICoreSettings::Run { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest creating methods to craft the Eigenlayer specific settings (and other protocols) so that this isn't the finished product. There are blueprint_id/service_id in this that shouldn't be expected to be supplied by end developers. Same with Symbiotic contract data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i.e. let config = ContextConfig::create_eigenlayer_config(...)
Also why is blueprint/service id even Some
? Shouldn't it be None
?
Overview
This PR focuses on improvements to the EigenLayer blueprints through the following changes: