feat: add IN_ADDR_ANY for V4 and V6 #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekohex
requested changes
Nov 8, 2024
There was a problem hiding this comment.
when I use your branch in my blueprint and run tests using blueprint test utils, I get the following error:
0: Failed to start the network: Other(Custom { kind: Other, error: Other(Right(Transport(Right(Io(Os { code: 98, kind: AddrInUse, message: "Address already in use" }))))) })
So I guess this broken.
tbraun96
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request introduces support for binding to IN_ADDR_ANY for both IPv4 and IPv6 addresses. This enhancement improves peer discovery, increases the probability of successful NAT traversal, and supports both internal testing and external peer connections.
Files Changed: