Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream locking #576

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

stream locking #576

wants to merge 1 commit into from

Conversation

ydarma
Copy link
Contributor

@ydarma ydarma commented May 27, 2022

This fixes the wait, run calls to enable use with object mode streams and asynchronous module loading.

fix #575 close #575

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022

Codecov Report

Merging #576 (49598f2) into master (12cc602) will decrease coverage by 1.21%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
- Coverage   96.36%   95.14%   -1.22%     
==========================================
  Files           4        4              
  Lines         632      639       +7     
  Branches      148      148              
==========================================
- Hits          609      608       -1     
- Misses         23       31       +8     
Impacted Files Coverage Δ
index.js 92.92% <33.33%> (-5.20%) ⬇️
lib/results.js 99.34% <0.00%> (-0.66%) ⬇️
lib/test.js 95.14% <0.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12cc602...49598f2. Read the comment docs.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (201e650) 96.76% compared to head (cb87b29) 95.72%.

Files Patch % Lines
index.js 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
- Coverage   96.76%   95.72%   -1.04%     
==========================================
  Files           4        4              
  Lines         742      749       +7     
  Branches      182      182              
==========================================
- Hits          718      717       -1     
- Misses         24       32       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +150 to 152
run();

if (wait) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this change mean it's breaking for anyone using wait?

@ljharb ljharb marked this pull request as draft January 10, 2024 18:37
@ljharb ljharb force-pushed the master branch 3 times, most recently from c16dde3 to 2ad86d4 Compare June 16, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create a stream then load ESM test modules
3 participants