Merge pull request #248 from tarkalabs/raja/unwantedlogsremoved

fix: unwanted logs removed in TUChip
tarkalabs · May 28, 2024 · 629a0ad · 629a0ad
2 parents d2be976 + 0a667a9
commit 629a0ad
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/tarka-ui/build.gradle.kts b/tarka-ui/build.gradle.kts
@@ -65,7 +65,7 @@ publishing {
       run {
         groupId = "com.tarkalabs"
         artifactId = getLibraryArtifactId()
-        version = "1.1.28"
+        version = "1.1.29"
         artifact("$buildDir/outputs/aar/tarka-ui-release.aar")
       }
     }

diff --git a/tarka-ui/src/main/java/com/tarkalabs/tarkaui/components/TUIChip.kt b/tarka-ui/src/main/java/com/tarkalabs/tarkaui/components/TUIChip.kt
@@ -1,6 +1,5 @@
 package com.tarkalabs.tarkaui.components
 
-import android.util.Log
 import androidx.compose.foundation.background
 import androidx.compose.foundation.border
 import androidx.compose.foundation.clickable
@@ -149,8 +148,6 @@ enum class ChipSize(val size: Dp) {
   val commonLabel = getCommonLabel(label)
   val leadingIcon = leadingIcon()
 
-  Log.e("TAG_CHIP", "TUIChipPreview: 888")
-
   when (type) {
     is ChipType.Assist -> {
       AssistChip(modifier = commonModifier,
@@ -339,11 +336,9 @@ data class TUIChipTags(
           label = "Something",
           onClick = {
             showSearchbar = true
-            Log.e("TAG_CHIP", "TUIChipPreview: TAG_CLICKED")
           },
           onDismissClick = {
             showSearchbar = !showSearchbar
-            Log.e("TAG_CHIP", "TUIChipPreview: 123")
           },
         )
         VerticalSpacer(space = 20)

diff --git a/tarka-ui/src/main/java/com/tarkalabs/tarkaui/components/TUITextRow.kt b/tarka-ui/src/main/java/com/tarkalabs/tarkaui/components/TUITextRow.kt
@@ -242,7 +242,7 @@ fun TUIDateStyle(
                         .align(Alignment.CenterVertically),
                     tint = TUITheme.colors.utilityOutline
                 )
-                if (style.startDate.isEmpty()) {
+                if (style.startDate == null) {
                     Text(
                         text = stringResource(id = style.primaryNotAvailableText),
                         style = TUITheme.typography.body7,
@@ -269,7 +269,7 @@ fun TUIDateStyle(
                         .align(Alignment.CenterVertically),
                     tint = TUITheme.colors.utilityOutline
                 )
-                if (style.endDate.isEmpty()) {
+                if (style.endDate == null) {
                     Text(
                         text = stringResource(id = style.primaryNotAvailableText),
                         style = TUITheme.typography.body7,
@@ -335,8 +335,8 @@ sealed class TextRowStyle {
     data class TitleWithDescription(val description: String) : TextRowStyle()
 
     data class DateStyle(
-        val startDate: String = "",
-        val endDate: String = "",
+        val startDate: String? = null,
+        val endDate: String? = null,
         @StringRes val primaryNotAvailableText: Int = R.string.not_availble,
     ) : TextRowStyle()
 
@@ -362,9 +362,10 @@ data class TUITextRowTags(
 @Preview(showBackground = true)
 @Composable
 fun TUITextRowPreview() {
+
     TUITextRow(
         title = "Duration", style = DateStyle(
-            "Jan 20 3000 friday march 32", "Jan 20 3000 friday march 32"
+            null, "Jan 20 3000 friday march 32"
         ), onTextRowClick = {
             Log.d("TAG", "TUITextRowPreview: ")
         }, onInfoIconClick = null