docs(pattern): add timeout section #2281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
force-pushed
the
timeout-pattern-docs
branch
from
cf17cd6 to
65e1656
Compare
manast
reviewed
Nov 17, 2023
There was a problem hiding this comment.
I don't see a lot of value in this pattern, I am worried it will lead users in the wrong direction, as you hint at the end, it is better to divide the job in smaller parts. Basically cancelling an async operation is going to result in a side effect that in the general case can result in any undesired effect.
roggervalf
commented
Mar 13, 2024
| clearTimeout(timeout); | ||
| resolve(); | ||
| }; | ||
| timeout = setTimeout(callback, ms); | ||
| abortController?.signal.addEventListener('abort', callback); | ||
| abortController?.signal.addEventListener('abort', callback, { once: true }); |
There was a problem hiding this comment.
https://github.com/southpolesteve/node-abort-controller/blob/master/index.d.ts#L17 autoremove abort listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.