fix(worker): mitigate job's locks extensions #2970
Open
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
force-pushed
the
fix/edge-case-job-lock-not-renewed-in-time
branch
from
108e452 to
2f5492c
Compare
roggervalf
reviewed
Dec 17, 2024
| @@ -911,6 +911,8 @@ will never work with more accuracy than 1ms. */ | |||
| const failed = await handleFailed(<Error>err); | |||
| return failed; | |||
| } finally { | |||
| jobsInProgress.delete(inProgressItem); | |||
There was a problem hiding this comment.
shouldn't this line be sufficient and the other extra references can be deleted as this line will be executed after completed and failed handlers?
There was a problem hiding this comment.
No because there are other async calls in between, so the lock extender could run in between as well and the there will be no lock for this job.
There was a problem hiding this comment.
before line 864 we also need to delete that inProgressitem as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix tries to resolve this issue: #2965 (comment)
And this one:
#2969