fix: dont fire events for about menu item (#237)

closes #215
tauri-apps · Oct 29, 2024 · 3b58a2e · 3b58a2e
1 parent cea276a
commit 3b58a2e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/.changes/about-macos-event.md b/.changes/about-macos-event.md
@@ -0,0 +1,5 @@
+---
+"muda": "patch"
+---
+
+Fix `PredefinedMenuItem::about` sending events where it shouldn't.
diff --git a/src/platform_impl/macos/mod.rs b/src/platform_impl/macos/mod.rs
@@ -1036,14 +1036,14 @@ impl MenuItem {
                     };
                 }
             }
-        }
+        } else {
+            if item.item_type == MenuItemType::Check {
+                item.set_checked(!item.is_checked());
+            }
 
-        if item.item_type == MenuItemType::Check {
-            item.set_checked(!item.is_checked());
+            let id = (*item).id().clone();
+            MenuEvent::send(crate::MenuEvent { id });
         }
-
-        let id = (*item).id().clone();
-        MenuEvent::send(crate::MenuEvent { id });
     }
 
     fn create(