feat(push): push notifications #1015
Draft
+273
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- feat(apns): add responders and events for APNS registration and error callbacks - feat(apns): call `registerForRemoteNotifications` within `did_finish_launching` - feat(apns): dispatch event to app for apns registration - feat(apns): gate push notifications behind `push-notifications` feature Relates-To: tauri-apps/tauri#11651 Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Package Changes Through 79cae51There are 1 changes which include tao with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
29 tasks
sgammon
commented
Nov 12, 2024
Comment on lines
+148
to
+157
| /// ## Push Tokens | ||
| /// | ||
| /// Emitted when registration completes and an application push token is made available; on Apple | ||
| /// platforms, this is the APNS token. On Android, this is the FCM token. | ||
| PushRegistration(PushToken), | ||
|
|
||
| /// ## Push Token Errors | ||
| /// | ||
| /// Emitted when push token registration fails. | ||
| PushRegistrationError(String), |
There was a problem hiding this comment.
not sure what you mean by "needs guard"
There was a problem hiding this comment.
@amrbashir these are my own comments to remind myself to add #[cfg(feature = "push-notifications") so that this code isn't included unless developers opt-in.
Comment on lines
+240
to
+241
| PushRegistration(token) => Some(PushRegistration(token)), | ||
| PushRegistrationError(error) => Some(PushRegistrationError(error)), |
Comment on lines
+70
to
+77
| decl.add_method( | ||
| sel!(application:didRegisterForRemoteNotificationsWithDeviceToken:), | ||
| did_register_for_apns as extern "C" fn(&Object, Sel, id, id), | ||
| ); | ||
| decl.add_method( | ||
| sel!(application:didFailToRegisterForRemoteNotificationsWithError:), | ||
| did_fail_to_register_for_apns as extern "C" fn(&Object, _: Sel, id, id), | ||
| ); |
src/platform_impl/macos/app_state.rs
Outdated
Comment on lines
420
to
426
| pub fn did_register_push_token(token_data: Vec<u8>) { | ||
| HANDLER.handle_nonuser_event(EventWrapper::StaticEvent(Event::PushRegistration(token_data))); | ||
| } | ||
|
|
||
| pub fn did_fail_to_register_push_token(err: String) { | ||
| HANDLER.handle_nonuser_event(EventWrapper::StaticEvent(Event::PushRegistrationError(err))); | ||
| } |
Signed-off-by: Sam Gammon <[email protected]>
|
@amrbashir could i get a workflow run? i'm curious how this does in ci. i think it should pass |
Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part 1 of a 3 part proposal for Push Notifications support in Tauri; this includes support in Tao for
AppDelegatemethods needed for APNS registration on macOS and iOS.Part of tauri-apps/tauri#11651.
Please see the PR to Tauri for a full description: