Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Unable to individually Name Release Assets #215

Open
ImmaZoni opened this issue Jan 31, 2022 · 1 comment
Open

[enhancement] Unable to individually Name Release Assets #215

ImmaZoni opened this issue Jan 31, 2022 · 1 comment
Labels
good first issue Good for newcomers type: feature request New feature or request

Comments

@ImmaZoni
Copy link

Building two .msi packages. One for Windows 11 & one for Windows 10, due to this when we go to publish the action creates a race condition and only uploads one of the two .msi packages (as they are the same name). An easy work around for this would be to be able to add a variable to the asset name such as "matrix.platform" or something along these lines.

My suggestion is to simply add assetName: as an option on the publish portion of the workflow.

@BrunoBernardino
Copy link

We would like to have this for https://github.com/padloc/padloc as well, in order to format the release assets in a consistent format with all other assets.

BrunoBernardino added a commit to padloc/padloc that referenced this issue Aug 5, 2022
Unfortunately [it's not yet possible for Tauri](tauri-apps/tauri-action#215), nor there's any GH action for that, _but_ [there's an API endpoint](https://docs.github.com/en/rest/releases/assets#update-a-release-asset) we could use.

Since it's only the Tauri assets that are not according to the new standard, I think it's fine to keep it something we manually update, otherwise we can try to build a script that taps into that endpoint, later.
@FabianLars FabianLars added type: feature request New feature or request good first issue Good for newcomers labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants