-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Resulting DMG has incorrect icon positions and window size #740
Comments
Hi, are you using an intel or arm mac locally? Which runner do you use in github? Asking because i just saw this create-dmg/create-dmg#171 |
I am using the Locally, I am using Intel. |
hmm, afaik macos-latest still uses intel until next month or so, so it's probably not that. I also found some old-ish releases from my action test repos and see the same issue. I also know that the create-dmg script indeed works differently in CI because it relies on Finder though i can't remember this being a general problem, i could swear it used to work 🤔 |
I've also just run into the same issue - it looks like running To confirm platform info:
|
Some more investigation, this seems to be a well documented issue w/ people noticing it from 2018 through 2023 (create-dmg/create-dmg#72) - where since you can't give |
Turns out this is expected behavior, a skip-jenkins flag is passed to the dmg script in CI
For us - setting CI: false in the env for this step solved it and it seems to work great! But be warned it looks like modifying the dmg aesthetics in CI can cause issues, so it's still unclear to us if it's working but flakily or whether its just that this issue has been fixed, eg, in current macOS or newer runners. |
I can confirm that adding |
Thanks for the research :) If there are no problems reported I will add it to the docs/examples with a comment to change it to true if build issues are encountered. |
Can confirm this also fixed our problem for adding a background image for the DMG. Note that now Fix: Discord issue: https://discord.com/channels/616186924390023171/1263642177439928441 |
@roniemartinez @jLynx Hey 👋, excuse me. This solution does work! But if you do this, is the app running stable? There won't be any potential risks, right? |
@ayangweb yes it's stable for us, no users have logged any issues |
Ok, thanks, I decided to use it! |
Tested only on v2 beta.
Building for MacOS with code signing and notarization creates a DMG with incorrect icon positions and window size as compared to a one built locally. There are no configuration change between environments.
Local build:
Workflow build using tauri-action:
The text was updated successfully, but these errors were encountered: