Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade MSRV to 1.77.2 to support Windows 7 #11205

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

lucasfernog
Copy link
Member

No description provided.

@lucasfernog lucasfernog requested review from a team as code owners October 3, 2024 10:48
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Package Changes Through e2237c1

There are 12 changes which include tauri with patch, tauri-utils with patch, tauri-runtime with patch, tauri-runtime-wry with patch, tauri-codegen with patch, tauri-macros with patch, tauri-plugin with patch, tauri-build with patch, tauri-cli with patch, tauri-macos-sign with patch, tauri-bundler with patch, tauri-driver with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-utils 2.0.0 2.0.1
tauri-macos-sign 2.0.0 2.0.1
tauri-bundler 2.0.0 2.0.1
tauri-runtime 2.0.0 2.0.1
tauri-runtime-wry 2.0.0 2.0.1
tauri-codegen 2.0.0 2.0.1
tauri-macros 2.0.0 2.0.1
tauri-plugin 2.0.0 2.0.1
tauri-build 2.0.0 2.0.1
tauri 2.0.0 2.0.1
@tauri-apps/cli 2.0.0 2.0.1
tauri-cli 2.0.0 2.0.1
tauri-driver 2.0.0 2.0.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@lucasfernog lucasfernog merged commit 0ab2b33 into dev Oct 3, 2024
28 checks passed
@lucasfernog lucasfernog deleted the fix/rust-1.77.2 branch October 3, 2024 11:07
@FabianLars
Copy link
Member

I don't have access to discord right now, what was the issue prompting for this change?

1.75 was the last version with proper Win7 support so I'd like to know what 1.77 brings us here.

@FabianLars
Copy link
Member

ah nevermind, the change was later than initially announced (in 1.72 blog they said 1.75 is the last one but later changed that to 1.77 i guess).
Still, we shouldn't hold on to that for ever, this already caused so much pain in v1. Of course, it's totally fair for the first versions so everyone can use v2.
Also, let's not forget that Rust still supports windows 7 just under a new target triple which imo is good enough for the future since tauri's win7 support itself is more like best effort itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants