Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Summary Metrics as overview for the Cluster View #588

Draft
wants to merge 8 commits into
base: dev
Choose a base branch
from
Draft

Adding Summary Metrics as overview for the Cluster View #588

wants to merge 8 commits into from

Conversation

theesen
Copy link

@theesen theesen commented Feb 3, 2021

  • New endpoint returning overall stats for a cluster (partitions, replica etc.)
  • Add overview table for the cluster on top of Topics List. Showing the number of partitions, replica and insync replica per cluster
  • Add FREE NOW as kafka-hq user

@theesen
Adding Summary Metrics as overview for the Cluster View
77fcffe 
+ New endpoint returning overall stats for a cluster (partitions, replica etc.)
+ Add overview table for the cluster on top of Topics List. Showing the number of partitions, replica and insync replica per cluster
+ Add FREE NOW as kafka-hq user
@theesen theesen mentioned this pull request Feb 3, 2021
Open
@theesen
Copy link
Author

theesen commented Feb 3, 2021

Build fails with ResourceNotFoundException: Connector connect-controller-test not found. Is this related to my changes or just the build broken in dev?

@tchiotludo
Copy link
Owner

The test are flakky on connect, need to find some to reproduced it :p

@theesen
Enhancing ClusterStats Model with additional metrics
5dd8997 
+ Topic Metrics
+ ConsumerGroup Metrics
+ Connect Metrics
+ SchemaRegistry Metrics
@theesen
Splitting up stats routes for each metric group
cb60c2a 
+ Connect, Schema and Consumer have a seperate route
+ add unittests
@theesen
Splitting up stats routes for each metric group
8f6dac1 
+ Connect, Schema and Consumer have a seperate route
+ add unittests
@theesen
resolve conflict
97374a8
@theesen
Copy link
Author

theesen commented Feb 11, 2021

@tchiotludo I have updated the routes and split them up. Do you mind having another look at it?
I am not sure when i'll have time to implement the frontend part. If you or someone else has time in between, feel free to add sth.

@tchiotludo
Copy link
Owner

@theesen thanks for the work, seems to be globally good as I see.
I don't know who can help here for the frontend ! but the backend is near the end as I see.

@theesen
Copy link
Author

theesen commented Mar 12, 2021 •
edited
Loading

@tchiotludo, took me some time to get back to this issue. Before I open the actual PR there is one question on the backend that needs to be answered. I am not sure what you had in mind with rebalancingGroups and emptyGroups, how would you calculate these stats?

@tchiotludo
Copy link
Owner

emptyGroups : group without any members
image

rebalancingGroups: group where current state is Rebalancing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theesen @tchiotludo