Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 support #29

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

gabriel-milan
Copy link
Contributor

Implement changes originally proposed at cboone@341b232. This allows Python3 support (tested with Python 3.7.3).

@tdaff
Copy link
Owner

tdaff commented Nov 8, 2020

Thanks for all the contributions!

This fix has come up a couple of times, but I think it's not the best solution. Unfortunately I've not had the time to address it properly, but I think the decoding should be happening much earlier. I've thrown together what I think it should look like, but not tested: https://github.com/tdaff/remote_ikernel/tree/py3-encoding (ideally a lot of Py2 code could also get purged).

@gabriel-milan
Copy link
Contributor Author

gabriel-milan commented Nov 9, 2020

Thank you for quick response!

I've seen these changes on cboone@341b232 and it kinda worked for me. I was working on adding few features for SLURM, such as GPU allocation and partition selection (added code here gabriel-milan@becf418) but I've faced some issues with pexpect that I just can't explain. I've posted on Stackoverflow but it seems that I'll get no help there unfortunately. Do you think that this might be due to the changes on this PR?

Btw, I've tested this branch of yours without any further changes and faced the same issue I've described on Stackoverflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants