fix numpy < 2.0.0 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 40 46 +6
Lines 1411 1620 +209
======================================
- Misses 1411 1620 +209 ☔ View full report in Codecov by Sentry. |
This was referenced Jun 26, 2024
|
My colleague tried this out (coincidentally right after you merged this PR) and says everything about the installation worked perfectly for him on two different machines. |
|
Perfect, thanks a lot for the feedback :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 2.0.0 is causing some issues in some dependencies, e.g. MONAI.
This PR should fix issues #70 and #71