Create functions for mask creation that return a ndarray #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was wondering if it would be possible to slightly refactor the mask creation so that the underlying functions return the numpy array instead of writing to an mrcfile. This makes it easier to use ttmask as a library.
Here is my attempt to do it (which I thought could be done easily by Copilot but that turned out to be a huge mistake). I've added some basic tests too, but I do think they could be neater.
Feel free to dismiss if you do not like it. Also happy to make any changes you suggest.