add initial sphere script as a cli option #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisterburt
reviewed
May 17, 2024
| @@ -38,6 +38,8 @@ classifiers = [ | |||
| dependencies = [ | |||
| "numpy", | |||
| "typer", | |||
| "einops", | |||
| "napari", | |||
There was a problem hiding this comment.
napari is a big dependency and only necessary for vis, consider removing (or gating behind a [vis] selector, can provide details)
| @@ -1,3 +1,3 @@ | |||
| import typer | |||
|
|
|||
| cli = typer.Typer(name="ttmask") | |||
| cli = typer.Typer(name="ttmask") | |||
There was a problem hiding this comment.
github likes having a newline at the end of files, auto format in pycharm normally does this
|
|
||
| typer.main.get_command_name = lambda name: name |
There was a problem hiding this comment.
this makes sense, do you understand what it's doing? :) can explain if not
as mentioned: would recommend removing and just having life be simple and dictated by the opinionated tool :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the initial sphere script (still needs soft edges etc to be added) as a command line option