Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be/#170 Comment 도메인 리팩토링 #171

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Be/#170 Comment 도메인 리팩토링 #171

merged 2 commits into from
Jul 17, 2023

Conversation

youKeon
Copy link
Collaborator

@youKeon youKeon commented Jul 15, 2023

🛠️ 변경사항

1. 프로젝트 조회 시 댓글 목록에 사용자 닉네임 포함

{
  "code": "P002",
  "message": "프로젝트 조회 성공",
  "data": {
    "id": 1,
    "projectName": "qwdwqqd",
    "content": "string",
    "description": "string",
    "thumbNail": "string",
    "commentsList": [
      {
        "commentId": 1,
        "nickname": "string1",
        "createdAt": "2023-07-01T16:01:14.251675",
        "content": "string",
        "childCount": 15
      }
    ],
    ...

2. 답글도 위와 동일하게 적용

{
  "code": "C001",
  "message": "답글 조회 성공",
  "data": [
    {
      "commentId": 2,
      "nickname": "string2",
      "createdAt": "2023-07-09T21:44:31.314361",
      "content": "string"
    },
    {
      "commentId": 3,
      "nickname": "string3",
      "createdAt": "2023-07-09T21:44:33.553718",
      "content": "string"
...

3. Comment 도메인의 테스트 코드 오류 수정

스크린샷 2023-07-16 01 27 33

☝️ 유의사항



👀 참고자료



❗체크리스트

  • 하나의 메소드는 최소의 기능만 하도록 설정했나요?
  • 수정 가능하도록 유연하게 작성했나요?
  • 필요 없는 import문이나 setter 등을 삭제했나요?
  • 기존의 코드에 영향이 없는 것을 확인하였나요?

@github-actions
Copy link

github-actions bot commented Jul 15, 2023

Unit Test Results

47 tests  ±0   27 ✔️ +6   4s ⏱️ -2s
12 suites ±0     0 💤 ±0 
12 files   ±0   20  - 6 

For more details on these failures, see this check.

Results for commit a41c2f5. ± Comparison against base commit a6fd5b0.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@kimhalin kimhalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

생각보다 리팩토링 할 게 없긴 했네요! 수고하셨습니당

@youKeon youKeon merged commit cf079cd into feature Jul 17, 2023
1 of 3 checks passed
@youKeon youKeon deleted the BE/#170 branch July 17, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants