FE/#215 메인 페이지, ProjectCard, Banner 컴포넌트 마이그레이션 #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BE/#209 controller mock mvc 테스트를 위한 userdetails 설정
- Swiper 컴포넌트에서 사용하지 않는 리스너 함수 제거 - Swiper 컴포넌트에 Autoplay 기능 추가
- API 호출 방식 변경 : axios -> fetch - useNavigate -> useRouter - react-query 사용을 위한 queryProvider 컴포넌트 생성
- img 태그 일부 'next/image'의 Image 컴포넌트로 변경 - API 호출 쿼리 파라미터 부분 수정
Mayreeel
reviewed
Sep 28, 2023
frontend/package.json
Outdated
| "next": "13.5.1", | ||
| "postcss": "8.4.30", | ||
| "prettier": "^3.0.3", | ||
| "react": "18.2.0", | ||
| "react-dom": "18.2.0", | ||
| "react-router-dom": "^6.16.0", |
There was a problem hiding this comment.
혹시 react-router-dom를 설치하신 이유가 있을까요??
There was a problem hiding this comment.
마이그레이션 하기 전에 에러가 떠서 설치했는데 지워야겠네요..! 확인 감사합니다😊
frontend/src/app/layout.tsx
Outdated
| <RecoilRootProvider>{children}</RecoilRootProvider> | ||
| <QueryProvider> | ||
| <RecoilRootProvider>{children}</RecoilRootProvider> | ||
| </QueryProvider> |
There was a problem hiding this comment.
어차피 react-query든 Recoil이든 Component를 한번 거쳐서 세팅해야되면 파일 하나로 합치는게 좋아보이네요!!
There was a problem hiding this comment.
헉...좋은 의견 감사합니다! 😄 그렇게 수정하도록 할게요
- recoilRootProvider, queryProvider 컴포넌트 -> Provider 컴포넌트 하나로 합치기 - react-router-dom 라이브러리 삭제
- yarn format:fix 실행
Yujin-Baek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ 변경사항
☝️ 유의사항
👀 참고자료
❗체크리스트