-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE/#215 메인 페이지, ProjectCard, Banner 컴포넌트 마이그레이션 #227
Conversation
BE/#209 controller mock mvc 테스트를 위한 userdetails 설정
- Swiper 컴포넌트에서 사용하지 않는 리스너 함수 제거 - Swiper 컴포넌트에 Autoplay 기능 추가
- API 호출 방식 변경 : axios -> fetch - useNavigate -> useRouter - react-query 사용을 위한 queryProvider 컴포넌트 생성
- img 태그 일부 'next/image'의 Image 컴포넌트로 변경 - API 호출 쿼리 파라미터 부분 수정
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!! 리뷰 한번 확인 부탁드려용
근데 왜 백엔드에서 작업한 파일까지 딸려온 걸까요?..
frontend/package.json
Outdated
"next": "13.5.1", | ||
"postcss": "8.4.30", | ||
"prettier": "^3.0.3", | ||
"react": "18.2.0", | ||
"react-dom": "18.2.0", | ||
"react-router-dom": "^6.16.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 react-router-dom를 설치하신 이유가 있을까요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마이그레이션 하기 전에 에러가 떠서 설치했는데 지워야겠네요..! 확인 감사합니다😊
frontend/src/app/layout.tsx
Outdated
<RecoilRootProvider>{children}</RecoilRootProvider> | ||
<QueryProvider> | ||
<RecoilRootProvider>{children}</RecoilRootProvider> | ||
</QueryProvider> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어차피 react-query든 Recoil이든 Component를 한번 거쳐서 세팅해야되면 파일 하나로 합치는게 좋아보이네요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헉...좋은 의견 감사합니다! 😄 그렇게 수정하도록 할게요
- recoilRootProvider, queryProvider 컴포넌트 -> Provider 컴포넌트 하나로 합치기 - react-router-dom 라이브러리 삭제
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~~!!
- yarn format:fix 실행
🛠️ 변경사항
☝️ 유의사항
👀 참고자료
❗체크리스트