-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : Recruitment 도메인 CRUD 구현 #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저희 PR 하나에 기능 하나로 하면 좋을 것 같아요! 보통 API 하나에 기능 하나로 여기는 경우가 많더라구요
/** | ||
* findTagListByName() 메서드 TagService로 옮기는 게 어떨까요?! | ||
* RecruitmentService에서 이 메서드를 사용해야 되는데 | ||
* Tag 찾는 기능을 위해 ProjectService와 의존관계를 맺는 건 아닌 거 같아서요! | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 좋습니다! 이런 문제는 건님께서 바로 수정하고 PR에 참고할 수 있도록 적어주시면 좋을 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 수정하겠습니다!!
@Builder | ||
@NoArgsConstructor | ||
@AllArgsConstructor | ||
public class CreateRecruitmentResponse { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저희 create 할 때 반환값 안 주기로 하지 않았나요?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 수정하겠습니다!!
@Builder | ||
@NoArgsConstructor | ||
@AllArgsConstructor | ||
public class UpdateRecruitmentResponse { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update도 마찬가지로요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 수정하겠습니다!!
🛠️ 변경사항
구현 기능
☝️ 유의사항
테스트 코드는 10월에 한 번에 작성하겠습니다.
👀 참고자료
❗체크리스트