feat : Recruitment 도메인 CRUD 구현 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimhalin
reviewed
Oct 1, 2023
Comment on lines
106
to
110
| /** | ||
| * findTagListByName() 메서드 TagService로 옮기는 게 어떨까요?! | ||
| * RecruitmentService에서 이 메서드를 사용해야 되는데 | ||
| * Tag 찾는 기능을 위해 ProjectService와 의존관계를 맺는 건 아닌 거 같아서요! | ||
| */ |
There was a problem hiding this comment.
넵 좋습니다! 이런 문제는 건님께서 바로 수정하고 PR에 참고할 수 있도록 적어주시면 좋을 것 같아요!
| @Builder | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| public class CreateRecruitmentResponse { |
There was a problem hiding this comment.
저희 create 할 때 반환값 안 주기로 하지 않았나요?!
| @Builder | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| public class UpdateRecruitmentResponse { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ 변경사항
구현 기능
☝️ 유의사항
테스트 코드는 10월에 한 번에 작성하겠습니다.
👀 참고자료
❗체크리스트