feat: workaround onResume when popping all

tekartik · Sep 19, 2023 · 96c707f · 96c707f
1 parent ead3cb5
commit 96c707f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/app_navigator/lib/src/content_navigator.dart b/app_navigator/lib/src/content_navigator.dart
@@ -220,18 +220,21 @@ class ContentNavigatorBloc extends BaseBloc {
 
   void _popUntilPathOrPush(BuildContext context, ContentPath path) {
     var found = false;
+
     Navigator.of(context).popUntil((route) {
-      // print('popUntil($path) checking ${route.settings.name}');
-      var matches = route.settings.name != null &&
-          path.matchesString(route.settings.name!);
-      if (!matches) {
-        if (_routeAwareManager != null) {
-          routeAwareManager.popPaths.add(route.settings.name!);
+      var name = route.settings.name;
+      if (name != null) {
+        var matches = path.matchesString(name);
+        if (!matches) {
+          if (_routeAwareManager != null) {
+            routeAwareManager.popPaths.add(name);
+          }
         }
-      }
 
-      found = found || matches;
-      return matches;
+        found = found || matches;
+        return matches;
+      }
+      return false;
     });
     // print('popUntil($path) found $found');
     if (!found) {

diff --git a/app_navigator/pubspec.yaml b/app_navigator/pubspec.yaml
@@ -1,6 +1,6 @@
 name: tekartik_app_navigator_flutter
 description: Experimental app navigator flutter
-version: 0.4.5
+version: 0.4.6
 publish_to: none
 
 environment: