Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unsafe option to skip confirmation prompts #694

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

oraclown
Copy link
Collaborator

Summary

  • Creates -u option for unsafe mode, which skips configuration prompts. Default is False, so the default will prompt you. This is a draft, so that can be changed based on further discussion.
  • Closes Add Flag for Skipping Config Confirmations  #693

Steps Taken to QA Changes

  • WIP

Checklist

This pull request is:

  • A documentation error, docs update, or typographical error fix
    • No tests or issue needed
  • A code fix
    • Please reference the related issue by including "Closes <link to issue>" in this Pull Request's summary section.
      • If no issue exists, please create a bug report issue
    • Please include tests. Fixes without tests will not be accepted unless it's related to the documentation only.
    • Please make sure docs are updated if need be
  • A feature implementation
    • Please reference the related issue by including "Closes <link to issue>" in this Pull Request's summary section.
      • If no issue exists, please create a feature enhancement issue
    • Please include tests
    • Please make sure docs updates are both thorough and easy to reproduce by somebody with limited knowledge of the feature that you are submitting

Happy engineering!

@oraclown oraclown requested a review from 0xSpuddy July 24, 2023 13:50
@oraclown
Copy link
Collaborator Author

Can also rename to something like "--skip-prompts" / "-sp" 🤷‍♂️

Copy link
Contributor

@0xSpuddy 0xSpuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested to confirm that these changes work as intended. Will go ahead and merge.

@0xSpuddy 0xSpuddy merged commit af8c54e into main Jul 27, 2023
4 checks passed
@0xSpuddy 0xSpuddy deleted the unsafe-mode branch July 27, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Flag for Skipping Config Confirmations
2 participants