Fix the signature verification #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoOl94
approved these changes
Nov 20, 2024
…ures The test attempts to deserialize a known transaction generated with a `devnet` node using the `alice` account.
There are now additional checks related to the computation of the signature. The assertion that was commented out is now working as expected, the issue was that the verification functions were used passing the digest as input while they expect the pre-image message (before it's hashed).
The change is needed now that the constant `RECOVERY_ID_ADDITION` has been modified, as the computed signature is different than before.
ptagl
force-pushed
the
pt/transaction_signature_verification
branch
from
ef20af0 to
b8445eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new unit test to check the correct verification of signatures.
The test takes a signed transaction generated on devnet using telos-native-docker and performs the following steps:
In order to make the test work it was necessary to update the constant
RECOVERY_ID_ADDITIONas the value used byantelope.rsdiffered from the one used by Wharfkit and Leap.This change impacts the computation of the signature, meaning that signing the same transaction before and after this change produces two different signatures, but the public key is always the same, making the change retro-compatible.
Some JSON test files used by the
MockProviderhad to be renamed though (as the mock transaction generated have a different signature now).