Implement logic for showing gb vs mb vs kb for account resources #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for open-block-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for obe-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kylanhurt
force-pushed
the
716-resource-unit
branch
from
dfc5093
to
5d233ec
Compare
Deploying with
|
| Latest commit: |
71e7e03
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eeeadd19.open-block-explorer.pages.dev |
| Branch Preview URL: | https://716-resource-unit.open-block-explorer.pages.dev |
kylanhurt
changed the title
donnyquixotic
suggested changes
Oct 16, 2023
Add account resource units for gb Clean up determineUnits work
kylanhurt
force-pushed
the
716-resource-unit
branch
from
7fcb42c
to
71e7e03
Compare
|
@donnyquixotic Comments handled |
donnyquixotic
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #716
Description
Max size takes precedence since it is arguably more important: used size is only relevant when a significant portion of max size. Logic ignores max size only for accounts that are privileged / system.
Test scenarios
Checked values on accounts with NET or RAM that is:
a.) less than 1mb
b) less than 1gb but greater than 1mb
c.) greater than 1gb (eosio.evm)
d.) system account (eosio)
Checklist: