Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move exact search matches to top of dropdown #817

Closed
wants to merge 1 commit into from

Conversation

kylanhurt
Copy link
Contributor

Fixes #816

Description

For accounts, exact matches are prioritized at the top of the search results.

Test scenarios

  1. Search eosio
  2. See if it shows up above eosio.null and eosio.evm, etc

Checklist:

image

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 45a22d8
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/656fa77358a3b70008e142ed
😎 Deploy Preview https://deploy-preview-817--obe-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for open-block-explorer ready!

Name Link
🔨 Latest commit 45a22d8
🔍 Latest deploy log https://app.netlify.com/sites/open-block-explorer/deploys/656fa77316eb0f0008d9b008
😎 Deploy Preview https://deploy-preview-817--open-block-explorer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 45a22d8
Status: ✅  Deploy successful!
Preview URL: https://6f6ef71d.open-block-explorer.pages.dev
Branch Preview URL: https://816-search-order.open-block-explorer.pages.dev

View logs

Copy link
Contributor

@donnyquixotic donnyquixotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@donnyquixotic
Copy link
Contributor

@kylanhurt #816 only affects system accounts that are manually added to the search results when the search term matches as they are not included in the table query. All other search results are already alphabetically sorted with the exact match on top. This is more easily resolved by just prepending (unshift()) instead of pushing the system accounts.
See fix here: df2e7f2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search results should show exact search results first
2 participants