Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces UAL and cleos with wharfkit #849

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Replaces UAL and cleos with wharfkit #849

merged 1 commit into from
Jul 11, 2024

Conversation

karynemayer
Copy link
Contributor

@karynemayer karynemayer commented May 13, 2024 •
edited
Loading

Description

Depends on #845

Changes were based on #646

Test scenarios

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage
  • I have updated relevant documentation and/or opened a separate issue to cover the updates (Issue URL: )

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented May 13, 2024 •
edited
Loading

Deploying open-block-explorer with  Cloudflare Pages  Cloudflare Pages

Latest commit: f757de3
Status: ✅  Deploy successful!
Preview URL: https://6f77e0cd.open-block-explorer.pages.dev
Branch Preview URL: https://wharfkit.open-block-explorer.pages.dev

View logs

@karynemayer karynemayer mentioned this pull request May 13, 2024
Open
9 tasks
Base automatically changed from pinia to develop May 15, 2024 12:10
@karynemayer karynemayer marked this pull request as ready for review May 15, 2024 16:31
@netlify Netlify
Copy link

netlify bot commented May 20, 2024 •
edited
Loading

✅ Deploy Preview for obe-staging ready!

Name Link
🔨 Latest commit f757de3
🔍 Latest deploy log https://app.netlify.com/sites/obe-staging/deploys/664b76ec1e83250008a58997
😎 Deploy Preview https://deploy-preview-849--obe-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented May 20, 2024 •
edited
Loading

✅ Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit f757de3
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/664b76ec365f8a0008eff998
😎 Deploy Preview https://deploy-preview-849--obe-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Viterbo
Viterbo approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@Viterbo Viterbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work !!! 💪
I learned a lot about wharfkit reviewing your PR. 👀

src/boot/wharf.ts
walletPlugins: [
new WalletPluginAnchor(),
new WalletPluginCleos(),
new WalletPluginPrivateKey('5Jtoxgny5tT7NiNFp1MLogviuPJ9NniWjnU4wKzaX4t7pL4kJ8s'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what is this private key doing here in plain text?

@pmjanus pmjanus merged commit 0e7f2e8 into develop Jul 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viterbo Viterbo Viterbo approved these changes

@pmjanus pmjanus Awaiting requested review from pmjanus

Assignees

@jaegerfe jaegerfe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karynemayer @Viterbo @jaegerfe @pmjanus