Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates WAX precision #854

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Updates WAX precision #854

merged 1 commit into from
Jul 11, 2024

Conversation

karynemayer
Copy link
Contributor

Description

Updates WAX's precision from 4 to 8 so users don't have to manually change it. It also removes the one instance found that used a hardcoded precision and not the one defined within the chain configuration file.

Test scenarios

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage
  • I have updated relevant documentation and/or opened a separate issue to cover the updates (Issue URL: )

@karynemayer karynemayer requested review from Viterbo and pmjanus May 20, 2024 18:55
@karynemayer karynemayer marked this pull request as ready for review May 20, 2024 18:55
Copy link

netlify bot commented May 20, 2024

Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 80e7123
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/664b9c8b8896430008e3d17e
😎 Deploy Preview https://deploy-preview-854--obe-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 20, 2024

Deploy Preview for obe-staging ready!

Name Link
🔨 Latest commit 80e7123
🔍 Latest deploy log https://app.netlify.com/sites/obe-staging/deploys/664b9c8b1238f600084322a7
😎 Deploy Preview https://deploy-preview-854--obe-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pmjanus pmjanus merged commit 12ce05f into develop Jul 11, 2024
10 checks passed
@pmjanus pmjanus deleted the wax-precision branch July 11, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants