5575: [TEST]: Fix retry mechanism in tests

Implements #5575 * add description
telstra · Feb 7, 2024 · 06bb5cd · 06bb5cd
1 parent 4a4b017
commit 06bb5cd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src-java/testing/functional-tests/build.gradle b/src-java/testing/functional-tests/build.gradle
@@ -1,7 +1,7 @@
 plugins {
     id 'groovy'
     id 'com.adarshr.test-logger' version '3.1.0'
-    id 'org.gradle.test-retry' version '1.3.1'
+    id 'org.gradle.test-retry' version '1.5.8'
 }
 description = 'Functional-Tests'
 

diff --git a/...ts/src/test/groovy/org/openkilda/functionaltests/spec/server42/Server42FlowRttSpec.groovy b/...ts/src/test/groovy/org/openkilda/functionaltests/spec/server42/Server42FlowRttSpec.groovy
@@ -92,7 +92,7 @@ class Server42FlowRttSpec extends HealthCheckSpecification {
 
         then: "Check if stats for forward are available"
         Wrappers.wait(STATS_FROM_SERVER42_LOGGING_TIMEOUT, 1) {
-            flowStats.of(flow.getFlowId()).get(FLOW_RTT, FORWARD, SERVER_42).hasNonZeroValues()
+            assert flowStats.of(flow.getFlowId()).get(FLOW_RTT, FORWARD, SERVER_42).hasNonZeroValues()
         }
 
         cleanup: "Revert system to original state"
@@ -559,16 +559,16 @@ class Server42FlowRttSpec extends HealthCheckSpecification {
         data << [
                  [
                          flowDescription: "vxlan",
-                         switchPair     : {switchPairs.all()
+                         switchPair     : switchPairs.all()
                                  .withBothSwitchesConnectedToServer42()
                                  .withBothSwitchesVxLanEnabled()
                                  .withSourceSwitchNotManufacturedBy(WB5164)
-                                 .random()} ,
+                                 .random(),
                          flowTap        : { FlowRequestV2 fl -> fl.encapsulationType = VXLAN }
                  ],
                  [
                          flowDescription: "qinq",
-                         switchPair     : {switchPairs.all().withBothSwitchesConnectedToServer42().random()},
+                         switchPair     : switchPairs.all().withBothSwitchesConnectedToServer42().random(),
                          flowTap        : { FlowRequestV2 fl ->
                              fl.source.vlanId = 10
                              fl.source.innerVlanId = 100